fix(tasks) Fix crontab schedules triggering with no last_run #97557
+24
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new crontab schedules are added they should align to their crontab schedule and not run off-schedule when there is no previous run information available. We can assume that the previous run was in the 'past' and use that as a starting point for the crontab schedule.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97557 +/- ##
==========================================
- Coverage 80.73% 80.62% -0.11%
==========================================
Files 8566 8560 -6
Lines 378963 376889 -2074
Branches 24538 24538
==========================================
- Hits 305948 303864 -2084
- Misses 72645 72655 +10
Partials 370 370 |
evanh
reviewed
Aug 11, 2025
| @@ -124,7 +124,7 @@ def monitor_value(self) -> str: | |||
| def is_due(self, last_run: datetime | None = None) -> bool: | |||
| """Check if the schedule is due to run again based on last_run.""" | |||
| if last_run is None: | |||
| return True | |||
| last_run = timezone.now() - timedelta(minutes=1) | |||
There was a problem hiding this comment.
Why is this hardcoded to one minute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new crontab schedules are added they should align to their crontab schedule and not run off-schedule when there is no previous run information available. We can assume that the previous run was in the 'past' and use that as a starting point for the crontab schedule.